Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jest, mock and test example #58

Merged
merged 8 commits into from
Sep 27, 2024
Merged

Add jest, mock and test example #58

merged 8 commits into from
Sep 27, 2024

Conversation

ernestoteo
Copy link
Contributor

@ernestoteo ernestoteo commented Aug 22, 2024 •
edited
Loading

@ernestoteo
Copy link
Contributor Author

ernestoteo commented Aug 29, 2024 •
edited
Loading

@paulpascal ,

I have added some mock a simple test for files as first step.
Would you please review this one before I proceed with checking the details of stock count form generated and adding items

@ernestoteo ernestoteo requested review from paulpascal and removed request for inromualdo September 2, 2024 09:09
paulpascal
paulpascal requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@paulpascal paulpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job @ernestoteo , we have a great starting point.

I left some comment inline

test/project-config/app_settings/base_settings.json Show resolved Hide resolved
test/project-config/forms/app/care_of_pregnant_women_and_others.xml Outdated Show resolved Hide resolved
test/project-config/forms/contact/c50_supervision_area-edit.properties.json Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
src/add-item.js Show resolved Hide resolved
paulpascal
paulpascal requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@paulpascal paulpascal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, Cool @ernestoteo
Really good clean up, we can start from, Can't wait to see start using it.

Can we get rid on the contact forms as well ?

PS: There is some conflicts with the master branch as well

test/project-config/forms/contact/c52_supervisor-create.xlsx Outdated Show resolved Hide resolved
paulpascal
paulpascal approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@paulpascal paulpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good @ernestoteo , we can move forward with this.

@ernestoteo ernestoteo merged commit d956af7 into master Sep 27, 2024
1 check passed
@ernestoteo ernestoteo deleted the 45_setup_unittest_mocks branch September 27, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulpascal paulpascal paulpascal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ernestoteo @paulpascal